Sheldan/abstracto
1
0
Fork 0
mirror of https://github.com/Sheldan/abstracto.git synced 2026-04-14 03:45:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

[SONAR] fixing major sonar issues

Browse Source
This commit is contained in:
Sheldan
2020-09-30 01:31:21 +02:00
parent 8e05bc90ea
commit f0d517af22
3 changed files with 26 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/service/management/ServerManagementServiceBean.java
View File

@@ -30,11 +30,8 @@ public class ServerManagementServiceBean implements ServerManagementService {
@Override
public AServer loadOrCreate(Long id) {
if(repository.existsById(id)) {
return repository.findById(id).get();
} else {
return createServer(id);
}
Optional<AServer> optional = repository.findById(id);
return optional.orElseGet(() -> createServer(id));
}
@Override

9
abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/service/management/UserManagementServiceBean.java
View File

@@ -7,6 +7,8 @@ import net.dv8tion.jda.api.entities.Member;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
import java.util.Optional;
@Component
@Slf4j
public class UserManagementServiceBean implements UserManagementService {
@@ -29,10 +31,7 @@ public class UserManagementServiceBean implements UserManagementService {
@Override
public AUser loadUser(Long userId) {
if(userRepository.existsById(userId)) {
return userRepository.findById(userId).get();
} else {
return this.createUser(userId);
}
Optional<AUser> optional = userRepository.findById(userId);
return optional.orElseGet(() -> this.createUser(userId));
}
}