Sheldan/abstracto
1
0
Fork 0
mirror of https://github.com/Sheldan/abstracto.git synced 2026-04-14 11:48:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

[AB-258] improving handling of request failures for urban dictionary

Browse Source
This commit is contained in:
Sheldan
2021-05-12 15:38:57 +02:00
parent d4edbb0d94
commit eca9e6ebf7
3 changed files with 52 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
abstracto-application/abstracto-modules/webservices/webservices-impl/src/main/java/dev/sheldan/abstracto/webservices/urban/service/UrbanServiceBean.java
View File

@@ -2,9 +2,11 @@ package dev.sheldan.abstracto.webservices.urban.service;
import com.google.gson.Gson;
import dev.sheldan.abstracto.webservices.urban.exception.NoUrbanDefinitionFoundException;
import dev.sheldan.abstracto.webservices.urban.exception.UrbanDictionaryRequestException;
import dev.sheldan.abstracto.webservices.urban.model.UrbanDefinition;
import dev.sheldan.abstracto.webservices.urban.model.UrbanResponse;
import dev.sheldan.abstracto.webservices.urban.model.UrbanResponseDefinition;
import lombok.extern.slf4j.Slf4j;
import okhttp3.OkHttpClient;
import okhttp3.Request;
import okhttp3.Response;
@@ -15,6 +17,7 @@ import org.springframework.stereotype.Component;
import java.io.IOException;
@Component
@Slf4j
public class UrbanServiceBean implements UrbanService {
@Autowired
@@ -30,6 +33,13 @@ public class UrbanServiceBean implements UrbanService {
public UrbanDefinition getUrbanDefinition(String query) throws IOException {
Request request = new Request.Builder().url(String.format(requestUrl, query)).get().build();
Response response = okHttpClient.newCall(request).execute();
if(!response.isSuccessful()) {
if(log.isDebugEnabled()) {
log.error("Failed to retrieve urban dictionary definition. Response had code {} with body {}.",
response.code(), response.body());
}
throw new UrbanDictionaryRequestException(response.code());
}
UrbanResponse urbanResponse = gson.fromJson(response.body().string(), UrbanResponse.class);
if(urbanResponse.getList().isEmpty()) {
throw new NoUrbanDefinitionFoundException();