replaced a bunch of places where the database loaded objects were referenced across threads, this might have lead to problems when lazy loading them

fixed starboard post template
fixed starboard post deletion

abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/command/CommandReceivedHandler.java

@@ -29,7 +29,6 @@ import net.dv8tion.jda.api.hooks.ListenerAdapter;
 import org.apache.commons.lang3.StringUtils;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.Lazy;
-import org.springframework.scheduling.annotation.Async;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Propagation;
 import org.springframework.transaction.annotation.Transactional;
@@ -65,7 +64,6 @@ public class CommandReceivedHandler extends ListenerAdapter {
     private RoleManagementService roleManagementService;
 
     @Override
-    @Async
     @Transactional
     public void onMessageReceived(@Nonnull MessageReceivedEvent event) {
         if(!event.isFromGuild()) {

abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/listener/ReactionUpdatedListener.java

@@ -7,7 +7,6 @@ import dev.sheldan.abstracto.core.service.FeatureFlagService;
 import dev.sheldan.abstracto.core.service.management.UserInServerManagementService;
 import dev.sheldan.abstracto.core.models.cache.CachedMessage;
 import dev.sheldan.abstracto.core.models.cache.CachedReaction;
-import dev.sheldan.abstracto.core.models.database.AUser;
 import dev.sheldan.abstracto.core.models.database.AUserInAServer;
 import dev.sheldan.abstracto.core.service.MessageCache;
 import dev.sheldan.abstracto.core.utils.EmoteUtils;
@@ -73,7 +72,7 @@ public class ReactionUpdatedListener extends ListenerAdapter {
         });
     }
 
-    private void addReactionIfNotThere(CachedMessage message, CachedReaction reaction, AUser userReacting) {
+    private void addReactionIfNotThere(CachedMessage message, CachedReaction reaction, AUserInAServer userReacting) {
         Optional<CachedReaction> existingReaction = message.getReactions().stream().filter(reaction1 ->
             EmoteUtils.compareAEmote(reaction1.getEmote(), reaction.getEmote())
         ).findAny();
@@ -81,28 +80,28 @@ public class ReactionUpdatedListener extends ListenerAdapter {
             message.getReactions().add(reaction);
         } else {
             CachedReaction cachedReaction = existingReaction.get();
-            Optional<AUser> any = cachedReaction.getUsers().stream().filter(user -> user.getId().equals(userReacting.getId())).findAny();
+            Optional<Long> any = cachedReaction.getUserInServersIds().stream().filter(user -> user.equals(userReacting.getUserInServerId())).findAny();
             if(!any.isPresent()){
-                cachedReaction.getUsers().add(userReacting);
+                cachedReaction.getUserInServersIds().add(userReacting.getUserInServerId());
             }
         }
     }
 
-    private void removeReactionIfThere(CachedMessage message, CachedReaction reaction, AUser userReacting) {
+    private void removeReactionIfThere(CachedMessage message, CachedReaction reaction, AUserInAServer userReacting) {
         Optional<CachedReaction> existingReaction = message.getReactions().stream().filter(reaction1 ->
             EmoteUtils.compareAEmote(reaction1.getEmote(), reaction.getEmote())
         ).findAny();
         if(existingReaction.isPresent()) {
             CachedReaction cachedReaction = existingReaction.get();
-            cachedReaction.getUsers().removeIf(user -> user.getId().equals(userReacting.getId()));
-            message.getReactions().removeIf(reaction1 -> reaction1.getUsers().isEmpty());
+            cachedReaction.getUserInServersIds().removeIf(user -> user.equals(userReacting.getUserInServerId()));
+            message.getReactions().removeIf(reaction1 -> reaction1.getUserInServersIds().isEmpty());
         }
     }
 
     @Transactional
     public void callAddedListeners(@Nonnull GuildMessageReactionAddEvent event, CachedMessage cachedMessage, CachedReaction reaction) {
         AUserInAServer userInAServer = userInServerManagementService.loadUser(event.getGuild().getIdLong(), event.getUserIdLong());
-        addReactionIfNotThere(cachedMessage, reaction, userInAServer.getUserReference());
+        addReactionIfNotThere(cachedMessage, reaction, userInAServer);
         addedListenerList.forEach(reactedAddedListener -> {
             FeatureConfig feature = featureFlagService.getFeatureDisplayForFeature(reactedAddedListener.getFeature());
             if(!featureFlagService.isFeatureEnabled(feature, event.getGuild().getIdLong())) {
@@ -143,7 +142,7 @@ public class ReactionUpdatedListener extends ListenerAdapter {
     @Transactional
     public void callRemoveListeners(@Nonnull GuildMessageReactionRemoveEvent event, CachedMessage cachedMessage, CachedReaction reaction) {
         AUserInAServer userInAServer = userInServerManagementService.loadUser(event.getGuild().getIdLong(), event.getUserIdLong());
-        removeReactionIfThere(cachedMessage, reaction, userInAServer.getUserReference());
+        removeReactionIfThere(cachedMessage, reaction, userInAServer);
         reactionRemovedListener.forEach(reactionRemovedListener -> {
             FeatureConfig feature = featureFlagService.getFeatureDisplayForFeature(reactionRemovedListener.getFeature());
             if(!featureFlagService.isFeatureEnabled(feature, event.getGuild().getIdLong())) {

abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/service/MessageCacheBean.java

@@ -4,8 +4,8 @@ import dev.sheldan.abstracto.core.exception.ChannelException;
 import dev.sheldan.abstracto.core.exception.GuildException;
 import dev.sheldan.abstracto.core.models.cache.CachedMessage;
 import dev.sheldan.abstracto.core.models.cache.CachedReaction;
-import dev.sheldan.abstracto.core.models.database.AUser;
 import dev.sheldan.abstracto.core.models.cache.*;
+import dev.sheldan.abstracto.core.service.management.UserInServerManagementService;
 import lombok.extern.slf4j.Slf4j;
 import net.dv8tion.jda.api.entities.*;
 import net.dv8tion.jda.api.requests.restaction.pagination.ReactionPaginationAction;
@@ -36,6 +36,9 @@ public class MessageCacheBean implements MessageCache {
     @Autowired
     private EmoteService emoteService;
 
+    @Autowired
+    private UserInServerManagementService userInServerManagementService;
+
     @Autowired
     @Lazy
     // needs to be lazy, because of circular dependency
@@ -51,7 +54,8 @@ public class MessageCacheBean implements MessageCache {
     }
 
 
-    @CachePut(key = "#message.messageId")
+    @Override
+    @CachePut(key = "#message.messageId.toString()")
     public CompletableFuture<CachedMessage> putMessageInCache(CachedMessage message) {
         log.info("Adding cached message to cache");
         return CompletableFuture.completedFuture(message);
@@ -74,7 +78,6 @@ public class MessageCacheBean implements MessageCache {
         return cachedMessageCompletableFuture;
     }
 
-    @Async
     @Override
     public void loadMessage(CompletableFuture<CachedMessage> future, Long guildId, Long textChannelId, Long messageId) {
         Optional<Guild> guildOptional = botService.getGuildById(guildId);
@@ -97,7 +100,6 @@ public class MessageCacheBean implements MessageCache {
     }
 
     @Override
-    @Async
     public void buildCachedMessageFromMessage(CompletableFuture<CachedMessage> future, Message message) {
         List<String> attachmentUrls = new ArrayList<>();
         message.getAttachments().forEach(attachment ->
@@ -147,21 +149,22 @@ public class MessageCacheBean implements MessageCache {
     }
 
     @Override
-    @Async
     public void getCachedReactionFromReaction(CompletableFuture<CachedReaction> future, MessageReaction reaction) {
         ReactionPaginationAction users = reaction.retrieveUsers().cache(false);
         CachedReaction.CachedReactionBuilder builder = CachedReaction.builder();
 
-        List<AUser> ausers = new ArrayList<>();
+        List<Long> ausers = new ArrayList<>();
         users.forEachAsync(user -> {
-            ausers.add(AUser.builder().id(user.getIdLong()).build());
+            if(reaction.getGuild() != null) {
+                ausers.add(userInServerManagementService.loadUser(reaction.getGuild().getIdLong(), user.getIdLong()).getUserInServerId());
+            }
             return false;
         }).thenAccept(o -> future.complete(builder.build()))
         .exceptionally(throwable -> {
             log.error("Failed to load reaction users.", throwable);
             return null;
         });
-        builder.users(ausers);
+        builder.userInServersIds(ausers);
         builder.emote(emoteService.buildAEmoteFromReaction(reaction.getReactionEmote()));
     }
 

abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/service/management/UserInServerManagementServiceBean.java

@@ -46,6 +46,11 @@ public class UserInServerManagementServiceBean implements UserInServerManagement
         return this.loadUser(member.getGuild().getIdLong(), member.getIdLong());
     }
 
+    @Override
+    public AUserInAServer loadUser(Long userInServerId) {
+        return userInServerRepository.getOne(userInServerId);
+    }
+
     @Override
     public AUserInAServer createUserInServer(Member member) {
         return this.createUserInServer(member.getGuild().getIdLong(), member.getIdLong());