refactored channel exception to have a unified interface to form the exception message

replaced getOne with findById in order to get optionals and handle those
some places still have the general abstracto run time exception

abstracto-application/abstracto-modules/experience-tracking/experience-tracking-impl/src/main/java/dev/sheldan/abstracto/experience/commands/SetExpRole.java

@@ -20,6 +20,7 @@ import org.springframework.stereotype.Component;
 
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Optional;
 
 @Component
 @Slf4j
@@ -39,14 +40,18 @@ public class SetExpRole extends AbstractConditionableCommand {
     public CommandResult execute(CommandContext commandContext) {
         Integer level = (Integer) commandContext.getParameters().getParameters().get(0);
         Long roleId = (Long) commandContext.getParameters().getParameters().get(1);
-        ARole role = roleManagementService.findRole(roleId, commandContext.getUserInitiatedContext().getServer());
-        AServer server = commandContext.getUserInitiatedContext().getServer();
-        if(!roleService.isRoleInServer(role)) {
-            throw new RoleException("Role not found.");
+        Optional<ARole> roleOpt = roleManagementService.findRole(roleId, commandContext.getUserInitiatedContext().getServer());
+        if(roleOpt.isPresent()) {
+            ARole role = roleOpt.get();
+            AServer server = commandContext.getUserInitiatedContext().getServer();
+            if(!roleService.isRoleInServer(role)) {
+                throw new RoleException("Role not found.");
+            }
+            log.info("Setting role  {} to be used for level {} on server {}", roleId, level, server.getId());
+            experienceRoleService.setRoleToLevel(role, level, server, commandContext.getUserInitiatedContext().getChannel());
+            return CommandResult.fromSuccess();
         }
-        log.info("Setting role  {} to be used for level {} on server {}", roleId, level, server.getId());
-        experienceRoleService.setRoleToLevel(role, level, server, commandContext.getUserInitiatedContext().getChannel());
-        return CommandResult.fromSuccess();
+       return CommandResult.fromError("Could not find role");
     }
 
     @Override

abstracto-application/abstracto-modules/experience-tracking/experience-tracking-impl/src/main/java/dev/sheldan/abstracto/experience/service/AUserExperienceServiceBean.java

@@ -1,5 +1,6 @@
 package dev.sheldan.abstracto.experience.service;
 
+import dev.sheldan.abstracto.core.exception.AbstractoRunTimeException;
 import dev.sheldan.abstracto.core.models.database.AChannel;
 import dev.sheldan.abstracto.core.models.database.AServer;
 import dev.sheldan.abstracto.core.models.database.AUserInAServer;
@@ -121,7 +122,9 @@ public class AUserExperienceServiceBean implements AUserExperienceService {
         Integer currentLevel = userExperience.getCurrentLevel() != null ? userExperience.getCurrentLevel().getLevel() : 0;
         if(!correctLevel.equals(currentLevel)) {
             log.info("User {} leveled from {} to {}", user.getUserReference().getId(), currentLevel, correctLevel);
-            userExperience.setCurrentLevel(experienceLevelManagementService.getLevel(correctLevel));
+            AExperienceLevel currentLevel1 = experienceLevelManagementService.getLevel(correctLevel)
+                    .orElseThrow(() -> new AbstractoRunTimeException(String.format("Could not find level %s", correctLevel)));
+            userExperience.setCurrentLevel(currentLevel1);
             return true;
         }
         return false;
@@ -289,13 +292,15 @@ public class AUserExperienceServiceBean implements AUserExperienceService {
         log.info("Retrieving rank for {}", userInAServer.getUserReference().getId());
         AUserExperience experience = userExperienceManagementService.findUserInServer(userInAServer);
         LeaderBoardEntryResult rankOfUserInServer = userExperienceManagementService.getRankOfUserInServer(experience);
+        AExperienceLevel currentLevel = experienceLevelManagementService.getLevel(rankOfUserInServer.getLevel())
+                .orElseThrow(() -> new AbstractoRunTimeException(String.format("Could not find level %s", rankOfUserInServer.getLevel())));
         AUserExperience aUserExperience = AUserExperience
                 .builder()
                 .experience(rankOfUserInServer.getExperience())
                 .user(userInAServer)
                 .messageCount(rankOfUserInServer.getMessageCount())
                 .id(userInAServer.getUserInServerId())
-                .currentLevel(experienceLevelManagementService.getLevel(rankOfUserInServer.getLevel()))
+                .currentLevel(currentLevel)
                 .build();
         return LeaderBoardEntry.builder().experience(aUserExperience).rank(rankOfUserInServer.getRank()).build();
     }

abstracto-application/abstracto-modules/experience-tracking/experience-tracking-impl/src/main/java/dev/sheldan/abstracto/experience/service/ExperienceLevelServiceBean.java

@@ -1,5 +1,6 @@
 package dev.sheldan.abstracto.experience.service;
 
+import dev.sheldan.abstracto.core.exception.AbstractoRunTimeException;
 import dev.sheldan.abstracto.experience.models.database.AExperienceLevel;
 import dev.sheldan.abstracto.experience.service.management.ExperienceLevelManagementService;
 import lombok.extern.slf4j.Slf4j;
@@ -46,7 +47,7 @@ public class ExperienceLevelServiceBean implements ExperienceLevelService {
 
     @Override
     public Long calculateExperienceToNextLevel(Integer level, Long currentExperience) {
-        AExperienceLevel nextLevel = experienceLevelManagementService.getLevel(level + 1);
+        AExperienceLevel nextLevel = experienceLevelManagementService.getLevel(level + 1).orElseThrow(() -> new AbstractoRunTimeException(String.format("Could not find level %s", level)));
         return nextLevel.getExperienceNeeded() - currentExperience;
     }
 

abstracto-application/abstracto-modules/experience-tracking/experience-tracking-impl/src/main/java/dev/sheldan/abstracto/experience/service/ExperienceRoleServiceBean.java

@@ -1,5 +1,6 @@
 package dev.sheldan.abstracto.experience.service;
 
+import dev.sheldan.abstracto.core.exception.AbstractoRunTimeException;
 import dev.sheldan.abstracto.core.models.database.AChannel;
 import dev.sheldan.abstracto.core.models.database.ARole;
 import dev.sheldan.abstracto.core.models.database.AServer;
@@ -38,7 +39,7 @@ public class ExperienceRoleServiceBean implements ExperienceRoleService {
      */
     @Override
     public void setRoleToLevel(ARole role, Integer level, AServer server, AChannel feedbackChannel) {
-        AExperienceLevel experienceLevel = experienceLevelService.getLevel(level);
+        AExperienceLevel experienceLevel = experienceLevelService.getLevel(level).orElseThrow(() -> new AbstractoRunTimeException(String.format("Could not find level %s", level)));
         unsetRole(role, server, feedbackChannel);
         experienceRoleManagementService.removeAllRoleAssignmentsForLevelInServer(experienceLevel, server);
         experienceRoleManagementService.setLevelToRole(experienceLevel, role, server);

abstracto-application/abstracto-modules/experience-tracking/experience-tracking-impl/src/main/java/dev/sheldan/abstracto/experience/service/management/ExperienceLevelManagementServiceBean.java

@@ -6,6 +6,7 @@ import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
 
 import java.util.List;
+import java.util.Optional;
 
 @Component
 public class ExperienceLevelManagementServiceBean implements ExperienceLevelManagementService {
@@ -30,8 +31,8 @@ public class ExperienceLevelManagementServiceBean implements ExperienceLevelMana
     }
 
     @Override
-    public AExperienceLevel getLevel(Integer level) {
-        return experienceLevelRepository.getOne(level);
+    public Optional<AExperienceLevel> getLevel(Integer level) {
+        return experienceLevelRepository.findById(level);
     }
 
     @Override

abstracto-application/abstracto-modules/experience-tracking/experience-tracking-impl/src/main/java/dev/sheldan/abstracto/experience/service/management/UserExperienceManagementServiceBean.java

@@ -1,5 +1,6 @@
 package dev.sheldan.abstracto.experience.service.management;
 
+import dev.sheldan.abstracto.core.exception.AbstractoRunTimeException;
 import dev.sheldan.abstracto.core.models.database.AServer;
 import dev.sheldan.abstracto.core.models.database.AUserInAServer;
 import dev.sheldan.abstracto.experience.models.database.LeaderBoardEntryResult;
@@ -31,7 +32,7 @@ public class UserExperienceManagementServiceBean implements UserExperienceManage
 
     @Override
     public AUserExperience createUserInServer(AUserInAServer aUserInAServer) {
-        AExperienceLevel startingLevel = experienceLevelManagementService.getLevel(0);
+        AExperienceLevel startingLevel = experienceLevelManagementService.getLevel(0).orElseThrow(() -> new AbstractoRunTimeException(String.format("Could not find level %s", 0)));
         return AUserExperience
                 .builder()
                 .experience(0L)
@@ -63,7 +64,7 @@ public class UserExperienceManagementServiceBean implements UserExperienceManage
             userExperience.setExperience(userExperience.getExperience() + experience);
             return userExperience;
         } else {
-            AExperienceLevel startingLevel = experienceLevelManagementService.getLevel(0);
+            AExperienceLevel startingLevel = experienceLevelManagementService.getLevel(0).orElseThrow(() -> new AbstractoRunTimeException(String.format("Could not find level %s", 0)));
             return AUserExperience
                     .builder()
                     .experience(experience)

abstracto-application/abstracto-modules/experience-tracking/experience-tracking-int/src/main/java/dev/sheldan/abstracto/experience/service/management/ExperienceLevelManagementService.java

@@ -3,6 +3,7 @@ package dev.sheldan.abstracto.experience.service.management;
 import dev.sheldan.abstracto.experience.models.database.AExperienceLevel;
 
 import java.util.List;
+import java.util.Optional;
 
 /**
  * Service responsible to create and retrieve {@link AExperienceLevel} objects in the database.
@@ -26,9 +27,9 @@ public interface ExperienceLevelManagementService {
     /**
      * Retrieves a {@link AExperienceLevel} according to the given level.
      * @param level The level of the wanted {@link AExperienceLevel} to look for
-     * @return If the level exists, returns the {@link AExperienceLevel}, if it does not exists, returns null.
+     * @return Returns an optional containing the {@link AExperienceLevel} if it exists, and null otherwise
      */
-    AExperienceLevel getLevel(Integer level);
+    Optional<AExperienceLevel> getLevel(Integer level);
 
     /**
      * Loads the complete level configuration and returns all found {@link AExperienceLevel} objects from the database.