Sheldan/abstracto
1
0
Fork 0
mirror of https://github.com/Sheldan/abstracto.git synced 2026-04-15 04:02:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

[AB-84] fixing incorrect calculation for agreement percentage

Browse Source
This commit is contained in:
Sheldan
2023-02-25 18:33:02 +01:00
parent f091559c49
commit 97895f5c56
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
abstracto-application/abstracto-modules/suggestion/suggestion-impl/src/main/java/dev/sheldan/abstracto/suggestion/service/SuggestionServiceBean.java
View File

@@ -279,8 +279,12 @@ public class SuggestionServiceBean implements SuggestionService {
Long disagreements = suggestionVoteManagementService.getDecisionsForSuggestion(suggestion, SuggestionDecision.DISAGREE); Long disagreements = suggestionVoteManagementService.getDecisionsForSuggestion(suggestion, SuggestionDecision.DISAGREE);
Long suggestionId = suggestion.getSuggestionId().getId(); Long suggestionId = suggestion.getSuggestionId().getId();
Long totalVotes = disagreements + agreements; Long totalVotes = disagreements + agreements;
float agreementPercentage = (float) agreements / (totalVotes) * 100; float agreementPercentage = 0;
float disAgreementPercentage = 100f - agreementPercentage; float disAgreementPercentage = 0;
if(totalVotes > 0) {
agreementPercentage = (((float) agreements) / totalVotes) * 100;
disAgreementPercentage = 100f - agreementPercentage;
}
SuggestionUpdateModel model = SuggestionUpdateModel SuggestionUpdateModel model = SuggestionUpdateModel
.builder() .builder()
.suggestionId(suggestionId) .suggestionId(suggestionId)