From 4ae6a154c75e37359fa2dfe96b9549a45e06b21e Mon Sep 17 00:00:00 2001 From: Sheldan <5037282+Sheldan@users.noreply.github.com> Date: Sun, 29 Dec 2024 21:10:27 +0100 Subject: [PATCH] [AB-xxx] fixing not being able to delete a giveaway key for which there is no giveaway --- .../service/management/GiveawayKeyManagementServiceBean.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/abstracto-application/abstracto-modules/giveaway/giveaway-impl/src/main/java/dev/sheldan/abstracto/giveaway/service/management/GiveawayKeyManagementServiceBean.java b/abstracto-application/abstracto-modules/giveaway/giveaway-impl/src/main/java/dev/sheldan/abstracto/giveaway/service/management/GiveawayKeyManagementServiceBean.java index 0dac461f1..69b113155 100644 --- a/abstracto-application/abstracto-modules/giveaway/giveaway-impl/src/main/java/dev/sheldan/abstracto/giveaway/service/management/GiveawayKeyManagementServiceBean.java +++ b/abstracto-application/abstracto-modules/giveaway/giveaway-impl/src/main/java/dev/sheldan/abstracto/giveaway/service/management/GiveawayKeyManagementServiceBean.java @@ -58,7 +58,9 @@ public class GiveawayKeyManagementServiceBean implements GiveawayKeyManagementSe @Override public void deleteById(Long id, Long serverId) { GiveawayKey key = giveawayKeyRepository.findById(new GiveawayKeyId(id, serverId)).orElseThrow(GiveawayKeyNotFoundException::new); - key.getGiveaway().setGiveawayKey(null); + if(key.getGiveaway() != null) { + key.getGiveaway().setGiveawayKey(null); + } giveawayKeyRepository.delete(key); }