Sheldan/abstracto
1
0
Fork 0
mirror of https://github.com/Sheldan/abstracto.git synced 2026-04-12 19:18:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[AB-246] changing parameter handling to only actually evaluate the necessary parameter handlers, this helps avoiding providing the wrong parameter to the actual command

Browse Source
This commit is contained in:
Sheldan
2021-05-02 17:40:52 +02:00
parent 23dd02312a
commit 2a5c462c35
43 changed files with 210 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
abstracto-application/abstracto-modules/statistic/statistic-impl/src/main/java/dev/sheldan/abstracto/statistic/emote/command/parameter/handler/TrackedEmoteParameterHandler.java
View File

@@ -33,10 +33,11 @@ public class TrackedEmoteParameterHandler implements CommandParameterHandler {
/**
* This {@link CommandParameterHandler} only handles {@link TrackedEmote}
* @param clazz The desired {@link Class} of a parameter
* @param value
* @return Whether or not the given {@link Class} will be handled by this {@link CommandParameterHandler}
*/
@Override
public boolean handles(Class clazz) {
public boolean handles(Class clazz, UnparsedCommandParameterPiece value) {
return clazz.equals(TrackedEmote.class);
}

3
abstracto-application/abstracto-modules/statistic/statistic-impl/src/main/java/dev/sheldan/abstracto/statistic/emote/command/parameter/handler/TrackedEmoteParameterParameterHandler.java
View File

@@ -37,10 +37,11 @@ public class TrackedEmoteParameterParameterHandler implements CommandParameterHa
/**
* This {@link CommandParameterHandler} only handles {@link TrackEmoteParameter}
* @param clazz The desired {@link Class} of a parameter
* @param value
* @return Whether or not the given {@link Class} will be handled by this {@link CommandParameterHandler}
*/
@Override
public boolean handles(Class clazz) {
public boolean handles(Class clazz, UnparsedCommandParameterPiece value) {
return clazz.equals(TrackEmoteParameter.class);
}

7
abstracto-application/abstracto-modules/statistic/statistic-impl/src/test/java/dev/sheldan/abstracto/statistic/emote/command/handler/TrackedEmoteParameterHandlerTest.java
View File

@@ -58,16 +58,19 @@ public class TrackedEmoteParameterHandlerTest {
@Mock
private TrackedEmote trackedEmote;
@Mock
private UnparsedCommandParameterPiece unparsedCommandParameterPiece;
private static final String WRONG_FORMATTED_INPUT = "input";
@Test
public void testHandleIncorrect() {
Assert.assertFalse(testUnit.handles(String.class));
Assert.assertFalse(testUnit.handles(String.class, unparsedCommandParameterPiece));
}
@Test
public void testHandleCorrect() {
Assert.assertTrue(testUnit.handles(TrackedEmote.class));
Assert.assertTrue(testUnit.handles(TrackedEmote.class, unparsedCommandParameterPiece));
}
@Test

7
abstracto-application/abstracto-modules/statistic/statistic-impl/src/test/java/dev/sheldan/abstracto/statistic/emote/command/handler/TrackedEmoteParameterParameterHandlerTest.java
View File

@@ -61,16 +61,19 @@ public class TrackedEmoteParameterParameterHandlerTest {
@Mock
private Command command;
@Mock
private UnparsedCommandParameterPiece unparsedCommandParameterPiece;
private static final String WRONG_FORMATTED_INPUT = "input";
@Test
public void testHandleIncorrect() {
Assert.assertFalse(testUnit.handles(String.class));
Assert.assertFalse(testUnit.handles(String.class, unparsedCommandParameterPiece));
}
@Test
public void testHandleCorrect() {
Assert.assertTrue(testUnit.handles(TrackEmoteParameter.class));
Assert.assertTrue(testUnit.handles(TrackEmoteParameter.class, unparsedCommandParameterPiece));
}
@Test