From 1d3c414d6bc3ab8274020ea813d4d77a17c0cda3 Mon Sep 17 00:00:00 2001 From: Sheldan <5037282+Sheldan@users.noreply.github.com> Date: Wed, 7 Oct 2020 20:42:19 +0200 Subject: [PATCH] [AB-144] fixing command key parameter handler and assignable post refreshing --- .../service/AssignableRolePlaceServiceBean.java | 4 ++++ .../core/command/handler/CommandKeyParameterHandler.java | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/abstracto-application/abstracto-modules/assignable-roles/assignable-roles-impl/src/main/java/dev/sheldan/abstracto/assignableroles/service/AssignableRolePlaceServiceBean.java b/abstracto-application/abstracto-modules/assignable-roles/assignable-roles-impl/src/main/java/dev/sheldan/abstracto/assignableroles/service/AssignableRolePlaceServiceBean.java index 17dd2fecd..afd041cb9 100644 --- a/abstracto-application/abstracto-modules/assignable-roles/assignable-roles-impl/src/main/java/dev/sheldan/abstracto/assignableroles/service/AssignableRolePlaceServiceBean.java +++ b/abstracto-application/abstracto-modules/assignable-roles/assignable-roles-impl/src/main/java/dev/sheldan/abstracto/assignableroles/service/AssignableRolePlaceServiceBean.java @@ -336,6 +336,10 @@ public class AssignableRolePlaceServiceBean implements AssignableRolePlaceServic @Override public CompletableFuture refreshAssignablePlacePosts(AssignableRolePlace place) { + if(place.getMessagePosts().isEmpty()) { + log.info("Trying to refresh an assignable place {} in server {} without any posts.", place.getId(), place.getServer().getId()); + return CompletableFuture.completedFuture(null); + } log.info("Refreshing assignable role place posts for assignable role place {} in server {}.", place.getId(), place.getServer().getId()); MessageToSend messageToSend = renderAssignablePlacePosts(place); List existingMessagePosts = place.getMessagePosts(); diff --git a/abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/command/handler/CommandKeyParameterHandler.java b/abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/command/handler/CommandKeyParameterHandler.java index 9606f3eeb..92d103a6b 100644 --- a/abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/command/handler/CommandKeyParameterHandler.java +++ b/abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/command/handler/CommandKeyParameterHandler.java @@ -10,7 +10,7 @@ public class CommandKeyParameterHandler implements CommandParameterHandler { @Override public boolean handles(Class clazz) { - return false; + return CommandParameterKey.class.isAssignableFrom(clazz); } @Override