From 080733957f7edb3d4d5a3b1ec2d010d2b3e79d6f Mon Sep 17 00:00:00 2001 From: Sheldan <5037282+Sheldan@users.noreply.github.com> Date: Thu, 18 May 2023 23:43:34 +0200 Subject: [PATCH] [AB-93] fixing not initializing the attached files --- .../sheldan/abstracto/core/service/ChannelServiceBean.java | 2 +- .../abstracto/core/templating/model/MessageToSend.java | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/service/ChannelServiceBean.java b/abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/service/ChannelServiceBean.java index 1d70b2009..b49f28e45 100644 --- a/abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/service/ChannelServiceBean.java +++ b/abstracto-application/core/core-impl/src/main/java/dev/sheldan/abstracto/core/service/ChannelServiceBean.java @@ -342,7 +342,7 @@ public class ChannelServiceBean implements ChannelService { throw new IllegalArgumentException("Message to send did not contain anything to send."); } } - if(messageToSend.getAttachedFiles() != null && !messageToSend.getAttachedFiles().isEmpty()) { + if(!messageToSend.getAttachedFiles().isEmpty()) { List files = messageToSend .getAttachedFiles() .stream() diff --git a/abstracto-application/core/core-int/src/main/java/dev/sheldan/abstracto/core/templating/model/MessageToSend.java b/abstracto-application/core/core-int/src/main/java/dev/sheldan/abstracto/core/templating/model/MessageToSend.java index 8a68db2e7..92b0121df 100644 --- a/abstracto-application/core/core-int/src/main/java/dev/sheldan/abstracto/core/templating/model/MessageToSend.java +++ b/abstracto-application/core/core-int/src/main/java/dev/sheldan/abstracto/core/templating/model/MessageToSend.java @@ -32,7 +32,8 @@ public class MessageToSend { /** * The file handle to send attached to the message. */ - private List attachedFiles; + @Builder.Default + private List attachedFiles = new ArrayList<>(); private MessageConfig messageConfig; private Long referencedMessageId; @Builder.Default @@ -44,7 +45,7 @@ public class MessageToSend { private Boolean ephemeral = false; public boolean hasFilesToSend() { - return attachedFiles != null && !attachedFiles.isEmpty(); + return !attachedFiles.isEmpty(); } @Getter